@nimrod-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).

@yoavGrs reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

    let suffix = node.hash.0.to_bytes_be();
    node.get_db_key(key_context, &suffix)
}

1. move to above usages
2. make it private, so it's clear that it's an internal util and not a real DB key

Suggestion:

fn db_key<L: Leaf>(
    node: &FactDbFilledNode<L>,
    key_context: &<L as HasStaticPrefix>::KeyContext,
) -> DbKey {
    let suffix = node.hash.0.to_bytes_be();
    node.get_db_key(key_context, &suffix)
}

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

Done. (I think, not sure about 1, I moved it up before the first usage)

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

did you push?

@ArielElp made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @nimrod-starkware, and @yoavGrs).

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

Did now